-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wait for content layer sync before starting dev server #12818
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d4e7186 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview dev-after-sync |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
CodSpeed Performance ReportMerging #12818 will not alter performanceComparing Summary
|
!preview dev-after-sync |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
224ccb6
to
d4e7186
Compare
I'm not sure what's causing the e2e test failures. If anyone wants to take a look then go ahead, otherwise I'll look into it when I'm back next week. |
Changes
Currently the dev server was started before content layer sync. This caused race conditions such as #12773, where the dev server would try to load a collection before it had synced.
This PR switches the order, waiting for the sync to complete before starting the dev server.
Testing
Tested with snapshot release.
The PR also has some changes to e2e tests. It seems that quite a few tests relied on the fact that the ordering of the content layer sync gave a bit of time after the dev server started before starting running tests. With this PR there's no longer that delay, causing some test failures. This PR adds a short delay in the test utils after the dev server starts so that the tests pass again.
Docs