Fix i18n current locale #12839
Open
Fix i18n current locale #12839
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 048dd65 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #12839 will not alter performanceComparing Summary
|
ematipico
reviewed
Dec 27, 2024
Comment on lines
+596
to
+600
| (routeData.pattern.test(url.pathname) | ||
| ? routeData | ||
| : routeData.fallbackRoutes.find((fallbackRoute) => | ||
| fallbackRoute.pattern.test(url.pathname), | ||
| )) ?? routeData; |
There was a problem hiding this comment.
In the past we used these operators and they made the readability worse, and we decided to use simple if/else. We would appreciate it if we keep using them
There was a problem hiding this comment.
Sure thing. Will rewrite the logic here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Adds similar logic to
computeCurrentLocaleas was used in #12709 to handle SSR manifests with fallback routes.Welcome feedback from a maintainer on whether there may be a more elegant solution to solve both of these - I dont have enough background on the decision process behind having such different manifests and i18n implementation between dev/SSR/SSG.
Docs
Just corrects a bug and inconsistent behavior across modes. No new docs needed.