-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests and functionality for handling double quotes in file names in FileTree #2641
base: main
Are you sure you want to change the base?
Add tests and functionality for handling double quotes in file names in FileTree #2641
Conversation
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
… in file and folder names
I think there is no need to implement this feature as proposed. There is already away to create a file name with spaces, if we use a tag like Maybe the only required change is in the docs to indicate that fact, but there is no need to complicate things with using quotes because they introduce too many cases when combined with markup tags. |
Description
Allows to use double quotes in
FileTree
component to indicate the full file name in cases where the file name contains white space. Like:- "my file name" this is the comment
Yes, but I don't know how to test the visuals from this project. I just added some tests for this case and change the code parsing the content of the list.
I would still need to update the docs