Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check returned idx instead of comparing it to zero (wc_GetPkcs8TraditionalOffset) #12

Closed
wants to merge 1 commit into from

Conversation

gasbytes
Copy link
Contributor

@gasbytes gasbytes commented Nov 25, 2024

Checking idx instead of comparing it to zero wc_GetPkcs8TraditionalOffset.

@gasbytes gasbytes changed the title check size instead of returned value (wc_GetPkcs8TraditionalOffset) check returned idx instead of comparing it to zero (wc_GetPkcs8TraditionalOffset) Nov 25, 2024
@gasbytes gasbytes requested a review from danielinux November 25, 2024 21:50
@gasbytes gasbytes removed the request for review from danielinux December 9, 2024 15:10
@gasbytes
Copy link
Contributor Author

gasbytes commented Dec 9, 2024

No longer needed since now we are using wc_EccPrivateKeyDecode directly. (#13)

@gasbytes gasbytes closed this Dec 9, 2024
@gasbytes gasbytes deleted the patch-pkcs8Traditional branch December 10, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant