Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XMSS/XMSS^MT support. #388

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Add XMSS/XMSS^MT support. #388

merged 3 commits into from
Nov 6, 2023

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Nov 3, 2023 •
edited
Loading

Description

Adds support for XMSS/XMSS^MT signatures.

Documentation

Updated the docs/PQ.md readme.

Building

Requires patched xmss-reference. See steps in docs/PQ.md readme.

The patch creates an addendum readme, patch_readme.md, with further comments explaining the changes made.

Testing

Tested with these targets:

  • built nrf52
  • added renode-nrf52 test case to github workflow
  • built and booted sim
  • imported externally generated XMSS pub key. Then created sha digest, externally signed digest, and incorporated signature.

@philljj philljj self-assigned this Nov 3, 2023
@philljj philljj requested a review from danielinux November 3, 2023 18:01
danielinux
danielinux requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@danielinux danielinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please add a test case to workflows/test-renode-nrf52.yml

@philljj philljj requested a review from danielinux November 5, 2023 16:32
@danielinux danielinux merged commit c31a213 into wolfSSL:master Nov 6, 2023
75 checks passed
@philljj philljj deleted the add_xmss_support branch November 13, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinux danielinux danielinux approved these changes

Assignees

@danielinux danielinux

@philljj philljj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philljj @danielinux