forked from magento/magento2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Using interface instead of model directly #1
Open
woutersamaey
wants to merge
3,325
commits into
2.1-develop
Choose a base branch
from
2.1-develop-PR-port-17124
base: 2.1-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving the current month from a UTC timestamp. magento#16585
…agento#16735 - Merge Pull Request magento#16735 from Karlasa/magento2:BP-PR-16559 - Merged commits: 1. 818519e 2. c11e329 3. 59a9f32
- Merge Pull Request magento#16731 from gelanivishal/magento2:2.1-develop-PR-port-16524 - Merged commits: 1. 71a3340
…n the js-translations.json magento#16720 - Merge Pull Request magento#16720 from sanganinamrata/magento2:2.1-develop-PR-port-13528 - Merged commits: 1. aa0e051
Accepted Public Pull Requests: - magento#16585: [Backport] Remove the timezone from the date when retrieving the current month from a UTC timestamp. (by @mageprince) - magento#16632: [Backport] Small refactoring to better code readability (by @ronak2ram) Fixed GitHub Issues: - magento#15940: Wrong end of month at Reports for Europe/Berlin time zone if month contains 31 day (reported by @Stepa4man) has been fixed in magento#16585 by @mageprince in 2.1-develop branch Related commits: 1. efbe4de
…n the js-translations.json magento#16720
…e \`Enable Qty Increments\` field magento#14380 - Merge Pull Request magento#14380 from simpleadm/magento2:backport/2.1-fix-product-import-enable-qty-inc - Merged commits: 1. ead41d9 2. 053fea2
…t page] magento#16526 - Merge Pull Request magento#16526 from hitesh-wagento/magento2:2.1-wrong-password-checkout - Merged commits: 1. 86ed9df 2. b5902e9
Accepted Public Pull Requests: - magento#16720: [Backport] Fix for magento#12081: missing translations in the js-translations.json (by @sanganinamrata) - magento#16731: [Backport] Removed extra code (by @gelanivishal) - magento#16735: [backport] magento#16559 fix icon color variable naming (by @Karlasa) Fixed GitHub Issues: - magento#12081: Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. (reported by @jhruehl) has been fixed in magento#16720 by @sanganinamrata in 2.1-develop branch Related commits: 1. aa0e051
…e times. Fixed integration tests.
… in Magento_Theme, Magento_Newsletter and Magento_Tax magento#16759 - Merge Pull Request magento#16759 from mageprince/magento2:2.1-develop-PR-port-16699 - Merged commits: 1. 9f06c5f 2. d6e647d
… in Magento_Sales and Magento_Paypal magento#16760 - Merge Pull Request magento#16760 from mageprince/magento2:2.1-develop-PR-port-16698 - Merged commits: 1. db30595
… in Magento_Sales and Magento_Paypal magento#16760
… in Magento_Theme, Magento_Newsletter and Magento_Tax magento#16759
Accepted Public Pull Requests: - magento#16760: [Backport] Declare module namespace before template path in Magento_Sales and Magento_Paypal (by @mageprince) - magento#16759: [Backport] Declare module namespace before template path in Magento_Theme, Magento_Newsletter and Magento_Tax (by @mageprince) - magento#16550: [Backport magento#16458] Add missing showInStore attributes (by @aschrammel)
magento#16761 - Merge Pull Request magento#16761 from gelanivishal/magento2:2.1-develop-PR-port-15346-2 - Merged commits: 1. 7a6217c
Accepted Public Pull Requests: - magento#17029: [Backport] Fixes Black color coding standard. (by @chirag-wagento) - magento#17092: [Backport] Remove forced setting of cache_lifetime to false in constructor and set default cache_lifetime to 3600 (by @mageprince) - magento#17111: [Backport] Fixed widget template rendering issue while rewriting widget block (by @gelanivishal) - magento#16809: [Backport] Remove double semicolon from the style sheets. (by @gelanivishal) - magento#17089: [Backport] Fixed comparison with 0 bug for TableRate shipping carrier (by @mageprince) - magento#17088: [Backport] Solved this issue : Drop down values are not showing in catalog produ� (by @mageprince) Fixed GitHub Issues: - magento#13595: loadCache for Block Magento\Theme\Block\Html\Footer dont work (reported by @larsroettig) has been fixed in magento#17092 by @mageprince in 2.1-develop branch Related commits: 1. 58698b5 - magento#16529: Rewriting product listing widget block breaks its template rendering. (reported by @sanganinamrata) has been fixed in magento#17111 by @gelanivishal in 2.1-develop branch Related commits: 1. deb05f1 2. 784d167 - magento#13006: Drop down values are not showing in catalog product grid magento2 (reported by @ramusadwika) has been fixed in magento#17088 by @mageprince in 2.1-develop branch Related commits: 1. c1f1313
- Merge Pull Request magento#17159 from gelanivishal/magento2:2.1-develop-PR-port-16861 - Merged commits: 1. af9129c
…on tax import magento#17160 - Merge Pull Request magento#17160 from gelanivishal/magento2:2.1-develop-PR-port-16873 - Merged commits: 1. e413d83 2. 274ba4b 3. 717f0a4
Accepted Public Pull Requests: - magento#17139: [Backport] Fixed a couple of spelling mistakes (by @mage2pratik) - magento#17105: [Backport] Fix negative basket total due to shipping tax residue (by @mage2pratik) - magento#17087: [Backport] Issues 13769. Fix wrong info about sent email in order sender. (by @mageprince) Fixed GitHub Issues: - magento#13769: Order Email Sender (reported by @pawcioma) has been fixed in magento#17087 by @mageprince in 2.1-develop branch Related commits: 1. add1e14
- Merge Pull Request magento#17136 from mage2pratik/magento2:remove-commented-code-4 - Merged commits: 1. 8099f16
…ences. magento#17157 - Merge Pull Request magento#17157 from gelanivishal/magento2:2.1-develop-PR-port-16182 - Merged commits: 1. ceb9d11 2. f8f2b20
Accepted Public Pull Requests: - magento#17160: [Backport] Improve "Invalid country code" error message on tax import (by @gelanivishal) - magento#17159: [Backport] Add Confirm Modal Width (by @gelanivishal) - magento#17090: [Backport] Inconsistent Redirect in Admin Notification Controller (by @mageprince) - magento#16992: [Backport] Refactor JavsScript for UrlRewrite module edit page. (by @chirag-wagento) Fixed GitHub Issues: - magento#15356: Refactore javascript for module URL rewrite (reported by @vgelani) has been fixed in magento#16992 by @chirag-wagento in 2.1-develop branch Related commits: 1. 846347d
Accepted Public Pull Requests: - magento#17157: [Backport] Removed double occurrence of keywords in sentences. (by @gelanivishal) - magento#17136: [Backport] Remove commented code (by @mage2pratik)
…gento#17239 - Merge Pull Request magento#17239 from tiagosampaio/magento2:2.1-develop-PR-port-16971 - Merged commits: 1. e06e7ac
- Merge Pull Request magento#17237 from tiagosampaio/magento2:2.1-develop-PR-port-17077 - Merged commits: 1. ebe636d
Accepted Public Pull Requests: - magento#17237: [Backport] Remove commented code (by @tiagosampaio)
Accepted Public Pull Requests: - magento#17239: [Backport] Fix misprint ('_requesetd' > '_requested') (by @tiagosampaio)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#17124
Description
Using interface instead of model directly
Contribution checklist