fixes #158
Merged
fixes #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nora01K
reviewed
Jul 2, 2024
Nora01K
requested changes
Jul 2, 2024
There was a problem hiding this comment.
#Checkliste Code
-
Gibt es keine offensichtliche Logikfehler im Code
-
Sind alle Variablen/Methoden etc. richtig und sprechend benannt (siehe Coding Guidelines -> Benennung)
-
Sind alle relevant Tests geschrieben ("relevant" siehe Code-Guidelines -> Tests)
-
Sind alle zuvor besprochenen Fehlerfälle abgedeckt? (StatusCodes)
-
Gibt es keine Code-Duplikationen (bsp schon implementierte Teile in Komponenten)
-
UI ist einheitlich (siehe Mockups) und Farben sind verwendet wie in Theme beschrieben
-
Ist die Codelänge in Ordnung? Wenn nein, wo gibt es Verbesserungspotenzial:
-
Ist der Code verständlich geschrieben, wenn Nein an welchen Stellen ist er zu kompliziert:
-
Allgemeine Kommentare:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.