Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error handling #170

Merged
merged 7 commits into from
Jul 21, 2024
Merged

fix error handling #170

merged 7 commits into from
Jul 21, 2024

Conversation

mabu2807
Copy link
Contributor

No description provided.

@mabu2807 mabu2807 changed the title fix error handling part 1 fix error handling Jul 18, 2024
@mabu2807 mabu2807 requested a review from Nora01K July 19, 2024 10:02
@mabu2807 mabu2807 self-assigned this Jul 19, 2024
Nora01K
Nora01K reviewed Jul 21, 2024
View reviewed changes
src/translation.js Outdated Show resolved Hide resolved
Nora01K
Nora01K requested changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@Nora01K Nora01K left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#Checkliste Code

  • Gibt es keine offensichtliche Logikfehler im Code

  • Sind alle Variablen/Methoden etc. richtig und sprechend benannt (siehe Coding Guidelines -> Benennung)

  • Sind alle relevant Tests geschrieben ("relevant" siehe Code-Guidelines -> Tests)

  • Sind alle zuvor besprochenen Fehlerfälle abgedeckt? (StatusCodes)

  • Gibt es keine Code-Duplikationen (bsp schon implementierte Teile in Komponenten)

  • UI ist einheitlich (siehe Mockups) und Farben sind verwendet wie in Theme beschrieben

  • Ist die Codelänge in Ordnung? Wenn nein, wo gibt es Verbesserungspotenzial:

  • Ist der Code verständlich geschrieben, wenn Nein an welchen Stellen ist er zu kompliziert:

  • Allgemeine Kommentare:

Nora01K
Nora01K approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@Nora01K Nora01K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passt so

@Nora01K Nora01K merged commit 662994e into main Jul 21, 2024
1 check passed
@Nora01K Nora01K deleted the final_fixes branch July 21, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nora01K Nora01K Nora01K approved these changes

Assignees

@mabu2807 mabu2807

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabu2807 @Nora01K