Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

get user posts endpunkt #17

Merged
merged 7 commits into from
Jan 18, 2024
Merged

get user posts endpunkt #17

merged 7 commits into from
Jan 18, 2024

Conversation

abramsmax
Copy link
Contributor

@abramsmax abramsmax commented Jan 14, 2024

Pull Request

Trello Ticket

Description

Endpunkt für persönlichen Nachrichten feed von Nutzern

Additional Remarks

@Frecherenkel60 Frecherenkel60 requested review from a team, NilsAbels and Frecherenkel60 and removed request for a team January 14, 2024 15:41
@abramsmax
Copy link
Contributor Author

Die Pagination ist in den Methoden RetrieveUserPosts und SearchUsers praktisch gleich, sollte man das auslagern?

@abramsmax abramsmax marked this pull request as ready for review January 16, 2024 17:09
@Frecherenkel60
Copy link
Member

Kannst da gerne eine Methode ähnlich createPaginatedResponse oder so machen, laut SonarQube gibt es eh noch etwas Code Duplication.

@abramsmax abramsmax requested a review from a team as a code owner January 17, 2024 12:53
@930C 930C force-pushed the main branch 3 times, most recently from a25a646 to f525ebc Compare January 18, 2024 12:01
@abramsmax
Copy link
Contributor Author

hab jetzt 2 neue methoden erstellt und paar sachen angepasst wegen deepsource aber eigentlich sollte es jetzt passen

@930C 930C force-pushed the main branch 2 times, most recently from 1e92f3c to a62d994 Compare January 18, 2024 15:11
930C added 2 commits January 18, 2024 19:04
# Conflicts:
#	internal/routing/handlers/user_handler.go
#	internal/routing/router.go
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@930C 930C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@930C 930C merged commit 8e974a9 into main Jan 18, 2024
3 checks passed
@930C 930C deleted the UserFeed branch January 18, 2024 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants