Feature/new ble #12
Open
Feature/new ble #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding getter for the singleton
* ci: add .deepsource.toml * ci: update .deepsource.toml * ci: update .deepsource.toml * ci: update .deepsource.toml * Finished the front end * Fixing View Model Inheritance and enter behavior * Fixing scoped namespaces --------- Co-authored-by: deepsource-io[bot] <42547082+deepsource-io[bot]@users.noreply.github.com> Co-authored-by: Alexander Lopez <[email protected]>
|
Here's the code health analysis summary for commits Analysis Summary
|
* Initial Context Quiz UI Enhanced (#6) * Adding Localization to context quiz * All Language Translation Now Works * Eveything works now sort off * style: format code with ClangFormat and dotnet-format This commit fixes the style issues introduced in 8ecca7b according to the output from ClangFormat and dotnet-format. Details: #11 --------- Co-authored-by: mazenham1d <[email protected]> Co-authored-by: hamidm <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
NoahNieberleMSOE
requested changes
Nov 26, 2024
|
|
||
| // Get the stream from the embedded resource | ||
| using var stream = await FileSystem.OpenAppPackageFileAsync(fileName); | ||
| using var reader = new StreamReader(stream); |
There was a problem hiding this comment.
Could you explicitly state the variable types?
| } | ||
|
|
||
| //private void OnDeviceAdvertised(object sender, DeviceEventArgs args) | ||
| //{ |
There was a problem hiding this comment.
Remove commented out code
|
|
||
| private void OnDeviceDiscovered(object sender, DeviceEventArgs args) | ||
| { | ||
| CheckAndRaiseEvent(args.Device); |
There was a problem hiding this comment.
Unless you foresee CheckAndRaiseEvent being used elsewhere in the code, could you move it back into this function?
|
|
||
| public async Task StartScanningAsync() | ||
| { | ||
| if (!_bluetoothManager.IsOn) |
There was a problem hiding this comment.
Good idea to check for this
|
|
||
| public void StopScanning() | ||
| { | ||
| _scanCancellationTokenSource?.Cancel(); |
There was a problem hiding this comment.
Could you do a null check?
| //{ | ||
| // // Build WebSocket handshake request | ||
| // var handshakeRequest = new StringBuilder(); | ||
| // handshakeRequest.AppendLine($"GET {webSocketUri.Host}{webSocketUri.PathAndQuery} HTTP/1.1"); |
| // //Dns.GetHostName will need to be removed if we want to test this nonlocally & Dns.GetHostEntry | ||
| // //will be replaced with whichever host the service is talking to | ||
| // string hostName = "o-chi.pcr.dog"; | ||
| // IPHostEntry ipHostInfo = Dns.GetHostEntry(hostName); |
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
| x:Class="Aha.Views.Website"> |
There was a problem hiding this comment.
Do we still use this?
| <!-- Top Color Bar --> | ||
| <BoxView | ||
| HeightRequest="50" | ||
| BackgroundColor="#C1E0F4" |
There was a problem hiding this comment.
This is just a nit but we could probably swap out the hardcoded background colors with the ones in the resource folder.
| SaveContextCommand = new Command(SaveContext); | ||
| } | ||
|
|
||
| private async void SaveContext(object obj) |
There was a problem hiding this comment.
Do we use "object"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.