[dotnet] Merge the 'RemoveAttributesStep' into the 'StoreAttributesStep'

[rolfbjarne]

Removing (and storing) the attributes earlier make it's possible for them not
to be marked. IOW the attribute type itself (and not just the decorations) can
be removed.

One side effect is that we'll have to manually mark the protocol wrapper type
referenced in the [Protocol] attribute, since the [Protocol] attribute is now
removed.

Inspired by / extracted from #14270.

[stephen-hawley]

👍

[vs-mobiletools-engineering-service2]

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 98f48a0a1a1d4dc5c48e3506fe119ee333e32a77 [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 98f48a0a1a1d4dc5c48e3506fe119ee333e32a77 [PR build]

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 98f48a0a1a1d4dc5c48e3506fe119ee333e32a77 [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 98f48a0a1a1d4dc5c48e3506fe119ee333e32a77 [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 98f48a0a1a1d4dc5c48e3506fe119ee333e32a77 [PR build]

[vs-mobiletools-engineering-service2]

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

3 tests crashed, 2 tests failed, 95 tests passed.

Failures

❌ cecil tests

🔥 Failed catastrophically on VSTS: test results - cecil (no summary found).

Html Report (VSDrops) Download

❌ dotnettests tests (Multiple platforms)

🔥 Failed catastrophically on VSTS: test results - dotnettests_multiple (no summary found).

Html Report (VSDrops) Download

❌ framework tests

🔥 Failed catastrophically on VSTS: test results - framework (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

1 tests failed, 7 tests passed.

• monotouch-test/Mac Catalyst [dotnet]/Release (static registrar) [dotnet]: Failed (Test run failed.
  Tests run: 3051 Passed: 2882 Inconclusive: 10 Failed: 1 Ignored: 168)

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

1 tests failed, 8 tests passed.

• monotouch-test/Mac [dotnet]/Release (static registrar, all optimizations) [dotnet]: Failed (Test run failed.
  Tests run: 3009 Passed: 2794 Inconclusive: 4 Failed: 1 Ignored: 214)

Html Report (VSDrops) Download

Successes

✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 3 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 98f48a0a1a1d4dc5c48e3506fe119ee333e32a77 [PR build]