-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rgen] Keep track of properties/methods/ctrs that use smart enums. #21876
Conversation
Smart enums are special when writing the bindings. Keep track of them in the code changes structures. For example, if a user add a BindingType attr to an enum, we should regenerated the methods that use it.
/azp run xamarin-macios-pr |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (9)
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/CodeChangesComparerTests.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/CodeChangesEqualityComparerTests.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Generator/DataModel/Method.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Generator/DataModel/Constructor.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/PropertyTests.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Generator/DataModel/Parameter.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Generator/DataModel/Property.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Generator/Extensions/TypeSymbolExtensions.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/MethodComparerTests.cs: Evaluated as low risk
|
|
/azp run xamarin-macios-pr |
Azure Pipelines successfully started running 1 pipeline(s). |
…amarin-macios into dev/mandel/param-is-smart-enum
/azp run xamarin-macios-pr |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run xamarin-macios-pr |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…amarin-macios into dev/mandel/param-is-smart-enum
/azp run xamarin-macios-pr |
Azure Pipelines successfully started running 1 pipeline(s). |
✅ [CI Build] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 105 tests passed. Failures❌ dotnettests tests (MacCatalyst)
Html Report (VSDrops) Download ❌ monotouch tests (macOS)
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
monotounch tests and donet tests are not affected by the changes, the failures are unrelated to the PR. |
Smart enums are special when writing the bindings. Keep track of them in the code changes structures. For example, if a user add a BindingType attr to an enum, we should regenerated the methods that use it.