-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msbuild] Show an error if an app tries to link with a static library when building for Hot Restart. #21877
base: main
Are you sure you want to change the base?
Conversation
… when building for Hot Restart. A fairly common problem is when apps try to use a static library when using Hot Restart on Windows (which isn't supported), and then they're confused when their app doesn't work. Improve this scenario by raising an error if an app tries to link with a static library when building for Hot Restart. Add an escape hatch in case someone still wants to build apps with static libraries using Hot Restart, since there are scenarios where it can be useful (while testing parts of an app that don't require any static libraries for instance).
/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff |
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run xamarin-macios-pr,xamarin-macios-apidiff |
Azure Pipelines successfully started running 1 pipeline(s). |
✅ [CI Build] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 107 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
A fairly common problem is when apps try to use a static library when using
Hot Restart on Windows (which isn't supported), and then they're confused when
their app doesn't work.
Improve this scenario by raising an error if an app tries to link with a
static library when building for Hot Restart.
Add an escape hatch in case someone still wants to build apps with static
libraries using Hot Restart, since there are scenarios where it can be useful
(while testing parts of an app that don't require any static libraries for
instance).