Allow overriding system time with custom time provider #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an interface for a custom time provider. Allow setting a time provider to override system time, in order to use a simulated time instead. Augment unit tests.
|
Thanks for the pull request. I have two comments:
|
Respond to code review comments by changing TimeProvider to return a CcsdsTime directly, rather than a Java time, and to be found by CcsdsTime by using the Java service loader facilities.
|
Applied both of your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an interface for a custom time provider. Allow setting a time provider to override system time, in order to use a simulated time instead. Augment unit tests.