-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primary Key Migration Woes #907
Open
parsonsmatt
wants to merge
3
commits into
master
Choose a base branch
from
matt/primary-key-migration-add
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
commented
May 13, 2019
again <- getMigration migrationAddCol | ||
liftIO $ again @?= [] | ||
describe "Add Primary key constraint on raw table" $ do | ||
it "should not be considered safe" $ runDb $ do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a primary key to a column is definitely not safe, because it's like adding a unique key to a column.
parsonsmatt
commented
May 13, 2019
Right migration <- parseMigration addPrimKey | ||
() <- runMigration addPrimKey | ||
again <- getMigration addPrimKey | ||
liftIO $ again @?= [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently fails on sqlite
with:
src/MigrationTest.hs:68:9:
2) Migration, Add Primary key constraint on raw table, works
uncaught exception: SqliteException
SQLite3 returned ErrorError while attempting to perform prepare "INSERT INTO \"from_raw_migration_backup\"(\"id\",\"name\",\"age\") SELECT \"id\",\"name\",\"age\" FROM \"from_raw_migration\"": table from_raw_migration_backup has no column named id
To rerun use: --match "/Migration/Add Primary key constraint on raw table/works/"
parsonsmatt
force-pushed
the
matt/primary-key-migration-add
branch
from
May 13, 2019 19:31
37d2d25
to
9bd38ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks #906
Test suite demonstrates problems
Before submitting your PR, check that you've:
@since
declarations to the HaddockAfter submitting your PR: