Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make yomo_wanted_target function optional in wasm #980

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

wujunzhuo
Copy link
Collaborator

Description

This is a bug fix pr which allows wasm runtimes do NOT implement yomo_wanted_target function.

@wujunzhuo wujunzhuo requested a review from woorui December 26, 2024 05:10
@wujunzhuo wujunzhuo requested a review from venjiang as a code owner December 26, 2024 05:10
Copy link

vercel bot commented Dec 26, 2024

@wujunzhuo is attempting to deploy a commit to the YoMo Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.74%. Comparing base (ba744f6) to head (9554ac5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cli/serverless/wasm/wazero.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage   46.48%   46.74%   +0.26%     
==========================================
  Files          97       97              
  Lines        6723     6721       -2     
==========================================
+ Hits         3125     3142      +17     
+ Misses       3401     3379      -22     
- Partials      197      200       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wujunzhuo wujunzhuo merged commit 11f2e9c into yomorun:master Dec 26, 2024
3 of 6 checks passed
@wujunzhuo wujunzhuo deleted the fix branch December 26, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants