Allow to sent on condition multiple times #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendOnConditionto run multiples times.This will allow us to have a better way of controlling when to send the data.
For example in the function
sendOnConditionI can write some code that ANY time an action ends with_FAILUREis dispatched I want to send that to Sentry, currently to do that I need to explicitly set all the actions in thesendOnattribute (as an array of all possibilities)What do you think about this @zalmoxisus?
Is there any reason why do you intentionally want this
sendOnConditionto run only the first time the condition is met??