client: limit spider scope and use own proxies #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
|
thc202
force-pushed
the
client/spider/limit-scope
branch
7 times, most recently
from
ebe2e60 to
95ad5ef
Compare
psiinon
approved these changes
Dec 30, 2024
thc202
changed the title
kingthorin
reviewed
Dec 30, 2024
addOns/client/src/main/java/org/zaproxy/addon/client/spider/ClientSpider.java
Outdated
Show resolved
Hide resolved
thc202
force-pushed
the
client/spider/limit-scope
branch
2 times, most recently
from
2e84d56 to
267856f
Compare
Limit to context, subtree, or target preventing any accesses outside the selected spider scope. Use own proxies when spidering instead of the main one, to limit the scope and allow later to track the requests of each action. Signed-off-by: thc202 <[email protected]>
thc202
force-pushed
the
client/spider/limit-scope
branch
from
267856f to
05da347
Compare
thc202
changed the title
kingthorin
reviewed
Dec 30, 2024
Comment on lines
+109
to
+113
| MessagesTable.class.getResource("/resource/icon/16/152.png")); | ||
|
|
||
| private static final ImageIcon NOT_ALLOWED_ICON = | ||
| DisplayUtils.getScaledIcon( | ||
| MessagesTable.class.getResource("/resource/icon/16/149.png")); |
There was a problem hiding this comment.
Could we give the icons useful filenames?
I know this is a holdover from code/history but I think it'll be more maintenance friendly in the long run.
There was a problem hiding this comment.
I guess these already exist, so maybe that's a change for another PR.
kingthorin
approved these changes
Dec 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit to context, subtree, or target preventing any accesses outside the selected spider scope.
Use own proxies when spidering instead of the main one, to limit the scope and allow later to track the requests of each action.