-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZEP-0006 introduce zarf package preview #7
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good zep, added some feedback
Just to make this clear. The command will be run on a package directory and not a already created package right? |
Signed-off-by: Austin Abro <[email protected]>
@phillebaba yes |
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
|
||
Users need an easier way to view what their zarf.yaml will look like after they're rendered by Zarf before `zarf package create`. A rendered zarf.yaml has had templating, imports, and flavors applied. | ||
|
||
This will be accomplished through a new CLI command - `zarf package preview` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not zarf package create --dry-run
or something similar? I don't see that being evaluated in the alternatives section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea. I did not think of it. That would provide the UX I'm looking for and be more in line with other tools
Flags: | ||
--set stringToString Specify package variables to set on the command line (KEY=value) (default []) | ||
-f, --flavor string The flavor of components to include in the resulting package (i.e. have a matching or empty "only.flavor" key) | ||
--confirm Confirm package preview without prompting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason to add confirmation for the preview, it doesn't provide any value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, on zarf package create
if a user has templates they haven't defined with --set
then they get an interactive prompt to define them. Confirm would skip that prompt. I can see the argument for getting rid of confirm and forcing users to use the --set
flag when they don't have templates
Co-authored-by: Maciej Szulik <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
zarf package preview
to provide a clean way to view templated packages before create #6