Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide AVOID_UB for some bugs found in GCC compiler testing #1785

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Provide AVOID_UB for some bugs found in GCC compiler testing #1785

wants to merge 3 commits into from
+54 −8

Conversation

Thar0
Copy link
Contributor

@Thar0 Thar0 commented Jan 7, 2025

Special thanks to @fig02 for the GCC playthrough that uncovered these, and for everyone else who looked into and discussed the problems.

The z_message_nes.c AVOID_UB is particularly nasty.. suggestions welcome

hensldm
hensldm approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@hensldm hensldm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't think of anything better for Message_DecodeNes unfortunately.

@AngheloAlf AngheloAlf added Merge-ready All reviewers satisfied, just waiting for CI and removed Needs-second-approval Second approval labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hensldm hensldm hensldm approved these changes

@AngheloAlf AngheloAlf AngheloAlf approved these changes

Assignees
No one assigned
Labels
Clean up Merge-ready All reviewers satisfied, just waiting for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thar0 @AngheloAlf @hensldm