Skip to content

Commit

Permalink
Show flags on countries frivolity
Browse files Browse the repository at this point in the history
  • Loading branch information
dumbmatter committed Oct 10, 2024
1 parent d10b474 commit 9d196ce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 0 additions & 2 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,6 @@ keep players on their real historical teams https://old.reddit.com/r/BasketballG

Player Bio Info: Button to equalize all country frequencies (to 1) https://old.reddit.com/r/BasketballGM/comments/1d59y20/monthly_suggestions_thread/l7e83r5/

Put each countries flag next to the country name in the "Countries" frivolity. https://old.reddit.com/r/BasketballGM/comments/1d59y20/monthly_suggestions_thread/l89p32u/

tests -> vitest
- normal tests - vitest had trouble with circular dependencies, like importing stuff from util returns undefined
- when browser testing is stable, could replace the karma/mocha stuff with vitest
Expand Down
5 changes: 4 additions & 1 deletion src/ui/views/Colleges.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import useTitleBar from "../hooks/useTitleBar";
import { getCols, helpers, useLocalPartial } from "../util";
import { DataTable } from "../components";
import { CountryFlag, DataTable } from "../components";
import type { View } from "../../common/types";
import { frivolitiesMenu } from "./Frivolities";
import { wrappedPlayerNameLabels } from "../components/PlayerNameLabels";
Expand Down Expand Up @@ -97,6 +97,9 @@ export const genView = (
window.encodeURIComponent(c.name),
])}
>
{type === "country" ? (
<CountryFlag className="me-1" country={c.name} />
) : null}
{type === "draftPosition" && c.name === "undrafted"
? "none"
: c.name}
Expand Down

0 comments on commit 9d196ce

Please sign in to comment.