-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules: lvgl: Rename the VDB custom section Kconfig name #83400
base: main
Are you sure you want to change the base?
modules: lvgl: Rename the VDB custom section Kconfig name #83400
Conversation
7bc0a10
to
41e7ee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks. Can you add an entry into migration guide that the option was renamed?
There are 4 Kconfig names about the "Draw Buffer". Rename 'VBD' to 'VDB' in Kconfig option 'LV_Z_*VBD*_CUSTOM_SECTION' to make name consistent. config LV_Z_VDB_ALIGN int "Rending buffer alignment" config LV_Z_VBD_CUSTOM_SECTION bool "Link rendering buffers to custom section" config LV_Z_DOUBLE_VDB bool "Use two rendering buffers" config LV_Z_VDB_SIZE int "Rendering buffer size" default 100 if LV_Z_FULL_REFRESH And the draw buffer definition is now: static uint8_t buf0[BUFFER_SIZE] #ifdef CONFIG_LV_Z_VDB_CUSTOM_SECTION Z_GENERIC_SECTION(.lvgl_buf) #endif __aligned(CONFIG_LV_Z_VDB_ALIGN); Signed-off-by: Haiyue Wang <[email protected]>
41e7ee6
to
72955fe
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @haiyuewa
LGTM
There are 4 Kconfig names about the "Draw Buffer". Rename the 'VBD' to 'VDB' in Kconfig option 'LV_Z_VBD_CUSTOM_SECTION' to make name consistent.
config LV_Z_VDB_ALIGN
int "Rending buffer alignment"
config LV_Z_VBD_CUSTOM_SECTION
bool "Link rendering buffers to custom section"
config LV_Z_DOUBLE_VDB
bool "Use two rendering buffers"
config LV_Z_VDB_SIZE
int "Rendering buffer size"
default 100 if LV_Z_FULL_REFRESH
And the draw buffer definition is now: