Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: lvgl: Rename the VDB custom section Kconfig name #83400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haiyuewa
Copy link
Contributor

There are 4 Kconfig names about the "Draw Buffer". Rename the 'VBD' to 'VDB' in Kconfig option 'LV_Z_VBD_CUSTOM_SECTION' to make name consistent.

config LV_Z_VDB_ALIGN
int "Rending buffer alignment"

config LV_Z_VBD_CUSTOM_SECTION
bool "Link rendering buffers to custom section"

config LV_Z_DOUBLE_VDB
bool "Use two rendering buffers"

config LV_Z_VDB_SIZE
int "Rendering buffer size"
default 100 if LV_Z_FULL_REFRESH

And the draw buffer definition is now:

static uint8_t buf0[BUFFER_SIZE]
#ifdef CONFIG_LV_Z_VDB_CUSTOM_SECTION
	Z_GENERIC_SECTION(.lvgl_buf)
#endif
		__aligned(CONFIG_LV_Z_VDB_ALIGN);

@zephyrbot zephyrbot added area: Shields Shields (add-on boards) platform: STM32 ST Micro STM32 platform: NXP NXP platform: Renesas RA Renesas Electronics Corporation, RA area: LVGL Light and Versatile Graphics Library Support labels Dec 26, 2024
@haiyuewa haiyuewa force-pushed the rename-VDB-custom-session-Kconfig branch from 7bc0a10 to 41e7ee6 Compare December 26, 2024 12:45
Copy link
Collaborator

@faxe1008 faxe1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks. Can you add an entry into migration guide that the option was renamed?

There are 4 Kconfig names about the "Draw Buffer". Rename 'VBD' to 'VDB'
in Kconfig option 'LV_Z_*VBD*_CUSTOM_SECTION' to make name consistent.

config LV_Z_VDB_ALIGN
	int "Rending buffer alignment"

config LV_Z_VBD_CUSTOM_SECTION
	bool "Link rendering buffers to custom section"

config LV_Z_DOUBLE_VDB
	bool "Use two rendering buffers"

config LV_Z_VDB_SIZE
	int "Rendering buffer size"
	default 100 if LV_Z_FULL_REFRESH

And the draw buffer definition is now:

	static uint8_t buf0[BUFFER_SIZE]
	#ifdef CONFIG_LV_Z_VDB_CUSTOM_SECTION
		Z_GENERIC_SECTION(.lvgl_buf)
	#endif
			__aligned(CONFIG_LV_Z_VDB_ALIGN);

Signed-off-by: Haiyue Wang <[email protected]>
@haiyuewa haiyuewa force-pushed the rename-VDB-custom-session-Kconfig branch from 41e7ee6 to 72955fe Compare December 26, 2024 13:30
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Dec 26, 2024
@haiyuewa
Copy link
Contributor Author

Good catch, thanks. Can you add an entry into migration guide that the option was renamed?

Done!

Copy link
Collaborator

@marwaiehm-st marwaiehm-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haiyuewa
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: LVGL Light and Versatile Graphics Library Support area: Shields Shields (add-on boards) platform: NXP NXP platform: Renesas RA Renesas Electronics Corporation, RA platform: STM32 ST Micro STM32 Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants