Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_nxp_enet_qos_mac: enable pass through of multicasts #83416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theadib
Copy link
Contributor

@theadib theadib commented Dec 27, 2024

eth_nxp_enet_qos: enable the multicast packet pass through

for eth module implementation where there is no hash table
the patch sets the PERMIT_MULTICAST bit to let multicast packets
pass the hardware mac filtering

tested for MCXN947

@pdgendt
Copy link
Collaborator

pdgendt commented Dec 27, 2024

Please force push to this PR instead of opening a new one each time.

@pdgendt
Copy link
Collaborator

pdgendt commented Dec 27, 2024

Your commit need a description body, use git commit --amend and force push after.

first check if the chip has a hosh module to futher filter MAC addresses
if not then enabling the pass through for all multicast protocols

Signed-off-by: Adib Taraben <[email protected]>
@theadib theadib force-pushed the eth_nxp_enet_qos_ipv6_multicast3 branch from e36db88 to 6648477 Compare December 27, 2024 12:29
@theadib
Copy link
Contributor Author

theadib commented Dec 27, 2024

Your commit need a description body, use git commit --amend and force push after.

thanks, that did the trick. Adib.

Copy link
Collaborator

@maass-hamburg maass-hamburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the driver is only for mcxn but I made those register macros specifically so we can use the SDK cnsis for other platforms since the names are not the same. I recognize that the fact it is an array here might be an unanticipated use case for those macros, but I think we want to support some other platform soon and this won't work. But not blocking because can handle this when we look to support those platform, surely there will be other issues existing anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Ethernet platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants