drivers: stepper: drv8424 use step_dir common code #83430
+62
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
bjarki-andreasen,
dipakgmx,
fabiobaltieri and
jilaypandya
jilaypandya
reviewed
Dec 28, 2024
| @@ -45,7 +45,7 @@ struct step_dir_stepper_common_config { | |||
| { \ | |||
| .step_pin = GPIO_DT_SPEC_GET(node_id, step_gpios), \ | |||
| .dir_pin = GPIO_DT_SPEC_GET(node_id, dir_gpios), \ | |||
| .dual_edge = DT_PROP(node_id, dual_edge_step), \ | |||
| .dual_edge = DT_PROP_OR(node_id, dual_edge_step, false), \ | |||
There was a problem hiding this comment.
This commit is not required, i suppose :)
There was a problem hiding this comment.
It's needed otherwise the dual-edge-step property needs to be part of either the driver dts or the stepper-controller dts binding. You might not want to do this if the IC does not support this setting. But if the property is not present in dts compilation with just DT_PROP will fail.
This way only drivers that have that setting can declare it in their own dts, otherwise its just false.
Adds a fallback for the dual-edge-step property in the step dir common code. Without this drivers using the common code would have to declare the dual-edge-step property so it can default to false when not set, even if the IC does not support adjusting it. Signed-off-by: Fabian Blatz <[email protected]>
Address issue where the timing source is not stopped upon step completion and not adjusting the actual position after performing a step. Signed-off-by: Fabian Blatz <[email protected]>
Adapt the drv8424 driver to use the common step dir interface. Signed-off-by: Fabian Blatz <[email protected]>
faxe1008
force-pushed
the
drv8424_common
branch
from
93e7efd to
d6aeb98
Compare
|
Found some issue in the common step_dir code that I missed, revealed by the drv8424 test suite. |
fabiobaltieri
approved these changes
Dec 28, 2024
jilaypandya
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drivers: stepper: drv8424 use step_dir common code
Now that the common code also has the timing source API available adjust the driver to leverage it.
CC @Irockasingranite