Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the return structure of the tickData from array to dictionary #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepgnly
Copy link

For efficient handling of the tickdata.

@rainmattertech
Copy link
Collaborator

Ah yes, this is the way to go, although this will be a major breaking change. We'll merge this once we figure out a way to roll out the changes.

Copy link

@girishgupta211-zz girishgupta211-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case please

@hemangjoshi37a
Copy link

It is very good idea to return dictionary instead of the list.
Very good pull request sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants