Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix webpack 5 config for live demo #504

Merged
merged 6 commits into from
Dec 31, 2023

Conversation

Vayel
Copy link
Contributor

@Vayel Vayel commented Dec 29, 2023

Fix #494

Test

  1. npm run build-demo
  2. Open packages/zmarkdown/public/index.html

Copy link
Member

@StaloneLab StaloneLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work, I cannot understand anything to Webpack, but I tested it locally and the live demo is working again!

I left two minor comments to be addressed, and I'll merge your changes right after.

README.md Outdated Show resolved Hide resolved
packages/zmarkdown/webpack.config.js Outdated Show resolved Hide resolved
@StaloneLab StaloneLab self-requested a review December 31, 2023 12:09
Copy link
Member

@StaloneLab StaloneLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no more linting problems, so apart from the README part, to which I answered, this is ready to be merged.

Unit testing is still failing because of package-lock.json, but no need to worry about this, I'll fix it once merged, as it can prove quite tricky not to mess up since we use a monorepo.

@StaloneLab
Copy link
Member

Ok, I thought you wanted to add something to the README but let's merge as is. I am ready to merge other changes you suggested if you want to work on them, such as:

  • adding a link to the package/zmd README in the main one;
  • adding some developer documentation in the README.

You might want to do this last one while working on something else, if you want to involve in the project.

@StaloneLab StaloneLab merged commit 06a8bc7 into zestedesavoir:master Dec 31, 2023
1 of 3 checks passed
@StaloneLab
Copy link
Member

Live demo is indeed working: https://zestedesavoir.github.io/zmarkdown/. Thanks again for your work!

@StaloneLab StaloneLab added this to the [email protected] milestone Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zmarkdown: fix live demo
2 participants