-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix webpack 5 config for live demo #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work, I cannot understand anything to Webpack, but I tested it locally and the live demo is working again!
I left two minor comments to be addressed, and I'll merge your changes right after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no more linting problems, so apart from the README
part, to which I answered, this is ready to be merged.
Unit testing is still failing because of package-lock.json
, but no need to worry about this, I'll fix it once merged, as it can prove quite tricky not to mess up since we use a monorepo.
Ok, I thought you wanted to add something to the README but let's merge as is. I am ready to merge other changes you suggested if you want to work on them, such as:
You might want to do this last one while working on something else, if you want to involve in the project. |
Live demo is indeed working: https://zestedesavoir.github.io/zmarkdown/. Thanks again for your work! |
Fix #494
Test
npm run build-demo
packages/zmarkdown/public/index.html