Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sonoff SNZB-04P device support with custom clusters #3665

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mguaylam
Copy link
Contributor

@mguaylam mguaylam commented Jan 3, 2025

Proposed change

Implement the tamper sensor of the device and disable the entity generation from the on/off cluster (it does not work).

Additional information

Fixes #3308
Requires zigpy/zha#345

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (8124411) to head (7b7778d).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3665      +/-   ##
==========================================
+ Coverage   89.85%   89.87%   +0.01%     
==========================================
  Files         322      323       +1     
  Lines       10379    10397      +18     
==========================================
+ Hits         9326     9344      +18     
  Misses       1053     1053              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mguaylam
Copy link
Contributor Author

mguaylam commented Jan 3, 2025

I think the configuration of the device fails because Sonoff does not allow reporting configuration. For this reason this PR might go without zigpy/zha#345 for a while until Sonoff update their device. The device has hardcoded reporting values for now anyway.

@mguaylam
Copy link
Contributor Author

mguaylam commented Jan 4, 2025

Oh nevermind. It's just slow at configuring. This device is a heavy sleeper.

@mguaylam mguaylam marked this pull request as ready for review January 4, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Sonoff SNZB-04p Zigbee Door/Window Sensor
1 participant