Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port official relay tutorial #420

Merged
merged 31 commits into from
Nov 10, 2023
Merged

Conversation

zth
Copy link
Owner

@zth zth commented Jan 15, 2023

No description provided.

@mbirkegaard mbirkegaard force-pushed the port-official-relay-tutorial branch from 105df3d to 7be098f Compare April 14, 2023 17:02
Copy link
Owner Author

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a quick look, will look more soon!

@mbirkegaard
Copy link
Collaborator

Just had a quick look, will look more soon!

@zth Second pass complete (🙂) and the examples repo fork has been similarly updated to fix various problems and inaccuracies.

As mentioned on the Discord, I actually think a tutorial that doesn't show how to make the backend is incomplete, but pieces of this can be utilised for a brand new tutorial. For now we may want to ship this or we may want to scrap it and do the new tutorial with ReScript 11, uncurried mode and all that. I might feel best about doing the latter.

@mbirkegaard mbirkegaard marked this pull request as ready for review October 8, 2023 14:14
@mbirkegaard
Copy link
Collaborator

Some markup needs fixing, but that should be it, I think

Copy link
Owner Author

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! 👍 Let's ship it.

@mbirkegaard mbirkegaard merged commit 160b414 into master Nov 10, 2023
6 checks passed
@mbirkegaard mbirkegaard deleted the port-official-relay-tutorial branch November 10, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants