Slack bridge: Update Slack bridge with Events API. #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
d22ae40 to
3ca5796
Compare
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
4 times, most recently
from
8ad1ab0 to
10bcf4f
Compare
|
ERROR: Label "buddy review" does not exist and was thus not added to this pull request. |
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
3 times, most recently
from
679f982 to
bc44575
Compare
PieterCK
added a commit
to PieterCK/python-zulip-api
that referenced
this pull request
Jun 26, 2024
The github action running the tests uses Python 3.8.18. When running ./tools/run-mypy using this Python version there will be linting errors related to importing the 'Salesforce' class. However, this is not a problem when running the mypy linter under Python 3.10. This commit ignores these linting error just so that the main PR zulip#826 can pass the github actions tests. I wouldn't recommend merging this commit to permanently fix this issue. Instead, it might be better to update the github actions to use a more recent Python version.
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
add6643 to
e682ef6
Compare
PieterCK
added a commit
to PieterCK/python-zulip-api
that referenced
this pull request
Jun 26, 2024
This is an optional commit that ignores linting errors in an unrelated file from zulip#826.
PieterCK
added a commit
to PieterCK/python-zulip-api
that referenced
this pull request
Jun 28, 2024
This is an optional commit that ignores linting errors in an unrelated file from zulip#826.
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
42e472c to
ded0ea7
Compare
rht
approved these changes
Jun 29, 2024
rht
reviewed
Jun 29, 2024
PieterCK
added a commit
to PieterCK/python-zulip-api
that referenced
this pull request
Jun 29, 2024
This is an optional commit that ignores linting errors in an unrelated file from zulip#826.
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
eda7a33 to
d8e6f71
Compare
|
Update: Addressed review and dropped support for RTM API |
|
@sbansal1999 I think this one's also ready for mentor review, please do check it out! Thanks |
PieterCK
added a commit
to PieterCK/python-zulip-api
that referenced
this pull request
Jul 3, 2024
This is an optional commit that ignores linting errors in an unrelated file from zulip#826.
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
d8e6f71 to
e0f20f6
Compare
PieterCK
added a commit
to PieterCK/python-zulip-api
that referenced
this pull request
Oct 20, 2024
This is an optional commit that ignores linting errors in an unrelated file from zulip#826.
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
e0f20f6 to
a394987
Compare
PieterCK
added a commit
to PieterCK/python-zulip-api
that referenced
this pull request
Oct 20, 2024
This is an optional commit that ignores linting errors in an unrelated file from zulip#826.
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
a394987 to
da246c4
Compare
PieterCK
added a commit
to PieterCK/python-zulip-api
that referenced
this pull request
Oct 20, 2024
This is an optional commit that ignores linting errors in an unrelated file from zulip#826.
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
da246c4 to
5f42745
Compare
PieterCK
added a commit
to PieterCK/python-zulip-api
that referenced
this pull request
Oct 20, 2024
This is an optional commit that ignores linting errors in an unrelated file from zulip#826.
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
5f42745 to
b4bcbf0
Compare
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
from
b4bcbf0 to
ff12189
Compare
|
Now that PR#30465 is merged, this is ready for review! |
timabbott
reviewed
Dec 13, 2024
| @@ -5,30 +5,42 @@ This is a bridge between Slack and Zulip. | |||
| ## Usage | |||
|
|
|||
| ### 1. Zulip endpoint | |||
There was a problem hiding this comment.
This likely needs to document this requires Zulip 10+, right?
There was a problem hiding this comment.
Yes. I added this in the documentation header for clarification:
# Slack <--> Zulip bridge
This is a bridge between Slack and Zulip.
> [!NOTE]
> This setup requires at least Zulip version 10.0.
## Usage
timabbott
reviewed
Dec 13, 2024
timabbott
reviewed
Dec 13, 2024
12 tasks
PieterCK
force-pushed
the
issue-slack-bridge-update-825
branch
2 times, most recently
from
65e0ca3 to
ba9a9a1
Compare
|
This is ready for review! |
Slack Bridge now uses the Slack Webhook integration to get messages accross from Slack instead of the legacy RTM API based we preivouslt use.
When using Slack Webhook integration to get messages from Slack to Zulip, we don't want to send back messages from the Slack integration bot. This prevents that by filtering out any messages from the Slack Webhook bots when sending messages from Zulip to Slack.. Fixes zulip#825.
This commit updates the Slack Bridge doc, primarily guiding the user to use our Slack Webhook integration. With significant rewriting by tabbott.
timabbott
force-pushed
the
issue-slack-bridge-update-825
branch
from
ba9a9a1 to
67c8034
Compare
|
Merged, after some more rewriting of the docs and moving the documentation commit to the end. Can you do some end-to-end testing of this end result and post about it in the #integrations channel? Once we've confirmed it's all happy, I can initiate a 9.4 server release and a release of this project to make this more readily available to end users. |
|
Ok, I should be able to do that tomorrow. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use Slack's legacy RTM API as the "listener" for messages from Slack to Zulip. This PR updates our Slack Bridge to use the Webhook integration to send messages from Slack to Zulip.
We now utilize the Slack Webhook integration for this part of the bridge, which is being updated to use the latest Event API in PR#30465. Here are the key changes in this PR :
new Slack Bridge documentation:
Fixes #825.