Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

Add highlight and show how to use some features #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

minervapanda
Copy link
Contributor

@minervapanda minervapanda commented Oct 12, 2016

I could not upload the whole video.
This pr addresses :
[x] Swipe to remove the chatbox
[x] Switching streams from the menu
[x] Private chat drawer
[x] Long press on message for more options

ezgif com-video-to-gif

Solves : Highlight and show how to use some features of the app which are not easily visible - #161

@smarx
Copy link

smarx commented Oct 12, 2016

Automated message from Dropbox CLA bot

@minervapanda, it looks like you've already signed the Dropbox CLA. Thanks!

@kunall17
Copy link
Collaborator

Thankyou for working on this!

@kunall17
Copy link
Collaborator

And also remove the commit a475f45 from this PR, as this is not related to this feature!

@minervapanda
Copy link
Contributor Author

Hi @kunall17 , I added the help option to the menu and similar way of implementation is in ChatBoxFeature java file. Give a look. We need to show different layouts for different demonstration for other features.
Also removed the unwanted commits

@brainwane
Copy link
Contributor

@minervapanda could you add a little more detail to the commit message (customs explained https://zulip.readthedocs.io/en/latest/version-control.html#commit-messages ) to list the features that get demonstrated in this new showcase?

showcaseView = new ShowcaseView.Builder(this)
.withNewStyleShowcase()
.setTarget(new ViewTarget(R.id.results, this))
.setContentTitle("Swipe to the Left")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't capitalize Left here.

showcaseView = new ShowcaseView.Builder(ChatBoxFeature.this)
.withNewStyleShowcase()
.setTarget(new ViewTarget(R.id.switch_stream, ChatBoxFeature.this)).setContentTitlePaint(titlePaint)
.setContentTitle("Press here to choose a stream")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we usually use "Tap" here instead of "Press".

@niftynei
Copy link
Contributor

Hey @minervapanda, have you had a chance to look over the suggestions from Sumana and Kunal yet?

@yadav-rahul
Copy link
Collaborator

@minervapanda Due to recent merges in master, merge conflicts have been created. Please try to resolve them.

@saketkumar
Copy link
Collaborator

@yadav-rahul This PR is no longer valid.
@timabbott @kunall17 I think this should be closed.

@zulipbot
Copy link
Member

zulipbot commented May 4, 2017

@minervapanda, your pull request has developed a merge conflict! Please review the most recent commit (f791888) for conflicting changes and resolve your pull request's merge conflicts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants