-
Notifications
You must be signed in to change notification settings - Fork 244
Add highlight and show how to use some features #210
base: master
Are you sure you want to change the base?
Conversation
Automated message from Dropbox CLA bot @minervapanda, it looks like you've already signed the Dropbox CLA. Thanks! |
Thankyou for working on this!
|
And also remove the commit a475f45 from this PR, as this is not related to this feature! |
Hi @kunall17 , I added the help option to the menu and similar way of implementation is in ChatBoxFeature java file. Give a look. We need to show different layouts for different demonstration for other features. |
@minervapanda could you add a little more detail to the commit message (customs explained https://zulip.readthedocs.io/en/latest/version-control.html#commit-messages ) to list the features that get demonstrated in this new showcase? |
showcaseView = new ShowcaseView.Builder(this) | ||
.withNewStyleShowcase() | ||
.setTarget(new ViewTarget(R.id.results, this)) | ||
.setContentTitle("Swipe to the Left") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't capitalize Left here.
showcaseView = new ShowcaseView.Builder(ChatBoxFeature.this) | ||
.withNewStyleShowcase() | ||
.setTarget(new ViewTarget(R.id.switch_stream, ChatBoxFeature.this)).setContentTitlePaint(titlePaint) | ||
.setContentTitle("Press here to choose a stream") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we usually use "Tap" here instead of "Press".
Hey @minervapanda, have you had a chance to look over the suggestions from Sumana and Kunal yet? |
@minervapanda Due to recent merges in |
@yadav-rahul This PR is no longer valid. |
@minervapanda, your pull request has developed a merge conflict! Please review the most recent commit (f791888) for conflicting changes and resolve your pull request's merge conflicts. |
I could not upload the whole video.
This pr addresses :
[x] Swipe to remove the chatbox
[x] Switching streams from the menu
[x] Private chat drawer
[x] Long press on message for more options
Solves : Highlight and show how to use some features of the app which are not easily visible - #161