add switch account icon #1180
add switch account icon #1180
Conversation
|
Hi! For design changes like this, let's start a discussion by sending your proposal in the #mobile channel and see if everyone agrees with the choice of icon. Also, please take a look at https://github.com/zulip/zulip-flutter/?tab=readme-ov-file#submitting-a-pull-request. The commit message needs to be fixed for this to be mergeable. It would also be helpful for you to include the source of the icon in your commit. |
|
@PIG208 can you check it out |
|
@chrisbobbe Please review this so I can proceed. |
There was a problem hiding this comment.
Thanks for the PR! We should also update the commit message so that it mentions where the icon comes from. Please also include a line, "Fixes: #1178", so that the commit closes the issue.
See "Zulip's commit style guide" linked here on how to do that: https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request
| @@ -1004,10 +1004,10 @@ packages: | |||
| dependency: transitive | |||
There was a problem hiding this comment.
The change to this file doesn't look intentional. I think we don't want to update this as it is irrelevant to this commit.
|
|
||
| @override | ||
| Widget buildLeading(BuildContext context) => const SizedBox.shrink(); | ||
|
|
There was a problem hiding this comment.
We should also remove this line, so we have 1 line between the two methods.
| @@ -540,10 +540,8 @@ class _SwitchAccountButton extends _MenuButton { | |||
|
|
|||
| @override | |||
| // TODO(design): choose an icon | |||
There was a problem hiding this comment.
Now that we have chosen the icon, this comment can be removed.
This PR introduces a new switch_account icon to the main menu of the application, which was previously empty. The icon improves the menu's usability by providing a clear visual indicator for account switching.
Related Issue #1178
The icon used in the menu is taken from Ant Design Icon Library
Screenshots
Iphone16 LightMode
iPad DarkMode