Simplify topic action sheet slightly #1182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always know the current visibility policy, so we can pass that unconditionally.
This makes it a bit more transparent what each of these cases is doing, by having fewer local abstractions with their own names.
Seeing a condition like `channelMuted != null`, it's not entirely clear what it means for a "channel muted" value to be null. We can express the point more directly as `subscription != null`, and then consult `isMuted` on the subscription.
gnprice
force-pushed
the
pr-topic-actions-nfc
branch
from
a11fdad to
cf26d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some small NFC followups on #1041, which I sketched last week while reviewing it but left aside while we were finishing last week's beta.