github: Fix weblate action's rights, and update generated code. #1192
Conversation
chrisbobbe
added
the
integration review
| git clone --depth=1000 -b main https://github.com/flutter/flutter ~/flutter | ||
| TZ=UTC git --git-dir ~/flutter/.git log -1 --format='%h | %ci | %s' --date=iso8601-local | ||
| echo ~/flutter/bin >> "$GITHUB_PATH" |
There was a problem hiding this comment.
This will need an update to match recent changes in ci.yml — see #1177 and the two PRs that closed it. (Just one command to add, thankfully.)
Probably this is a sign we should factor this part out as a tiny shell script in its own file. I'd be happy to do that as a followup after this PR, though.
|
|
||
| - name: Update generated code | ||
| run: | | ||
| ./tools/check l10n --fix |
There was a problem hiding this comment.
nit:
| ./tools/check l10n --fix | |
| tools/check l10n --fix |
The rule is that once there's a slash in the command name, it means a file by that name, and there's no search in PATH (or for shell functions or builtins). Docs:
https://www.gnu.org/software/bash/manual/bash.html#Command-Search-and-Execution
(and POSIX says the same thing but is more annoying to reference:
https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/utilities/V3_chap02.html#tag_18_09_01 )
So a leading ./ is useful only as a trick to get a slash in there when the file's name would otherwise have no slash.
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Fetch and merge from Weblate |
There was a problem hiding this comment.
nit: once these steps are separated by blank lines, I feel like I want the enclosing jobs: to be separated by a blank line from its siblings — otherwise it feels like a bit of a visual-hierarchy inversion
|
Also it'd be great to get to test this (and similar PRs) before merging it to main. I floated a possible solution for that just now in the chat thread: |
No description provided.