lightbox: Use a friendlier format for the date #1197
+253
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the timestamp format from Mar 31, 2023 15:09:51 to a more readable Mar 31, 2023 at 3:09 PM. Added proper localization support to adapt timestamps to the user's language and region preferences. Optimized the timestamp logic to ensure accurate categorization into Today, Yesterday, or specific dates. Fixes: zulip#45
| @@ -249,7 +249,7 @@ void main() { | |||
| matching: find.textContaining(findRichText: true, | |||
| eg.otherUser.fullName))); | |||
| check(labelTextWidget.text.toPlainText()) | |||
| .contains('Jul 23, 2024 23:12:24'); | |||
| .contains('Jul 23, 2024 at 11:12 PM'); | |||
There was a problem hiding this comment.
I think you should add checks for the other behaviors as well like "a few minutes ago".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
Changed the timestamp format from
Mar 31, 2023 15:09:51to a more readableMar 31, 2023 at 3:09 PM.Added proper localization support to adapt timestamps to the user's language and region preferences.
Optimized the timestamp logic to ensure accurate categorization into
Today,Yesterday, or specific dates.Modified test also to ensure the correct format of date.
Issue: #45
Screenshots: