Fix channel navigation when tapping recipient header areas #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Before we can review this, it will need a test — see our README: https://github.com/zulip/zulip-flutter#submitting-a-pull-request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the tap target behavior in the recipient header of channel messages. Previously, tapping above or below the channel name would navigate to the topic view instead of the channel view.
The fix adds
behavior: HitTestBehavior.opaqueto the GestureDetector which makes the entire area (including padding spaces) respond to taps.The fix improves the header's usability by ensuring the entire channel section responds correctly to taps, making navigation more intuitive.
Issue: #1179
Screencast:
solutionPoc.mp4