Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to get user's alert words. #67

Closed
wants to merge 1 commit into from

Conversation

Anupam-dagar
Copy link
Contributor

@Anupam-dagar Anupam-dagar commented Aug 23, 2018

Issue: #63
@aero31aero The test was passing but while trying on a server I was getting the following error. I wasn't able to resolve it, can you take a look at it.
screenshot from 2018-08-23 11-03-47

@aero31aero
Copy link
Member

Perhaps because you're trying to fetch something but have no alert words to fetch? Just a hunch, but I'll investigate soon.

@Anupam-dagar
Copy link
Contributor Author

Yup, my current user don't have any alert words. I think instead of this error, we should show the generic "no alert words for user found" error if possible as it will make the error clear to understand.

@aero31aero
Copy link
Member

aero31aero commented Aug 28, 2018

@Anupam-dagar there was a small typo in the example/users.js code: apikey => apiKey. Fixing that fixed this for me, and the code works as expected. We should probably work on testing/reworking our examples sometime.

@Anupam-dagar
Copy link
Contributor Author

@aero31aero I will keep a better look on typo's from next PR onwards.

@aero31aero
Copy link
Member

Merged manually after some changes, thanks @Anupam-dagar.

@aero31aero aero31aero closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants