Opens message links popup menu #424
Conversation
shreyamalviya
force-pushed
the
links-popup
branch
from
9990420 to
d1425b8
Compare
shreyamalviya
force-pushed
the
links-popup
branch
from
7228bcd to
3fc02b1
Compare
zulipterminal/helper.py
Outdated
| os.mkdir(img_dir_path) | ||
| except FileExistsError: | ||
| pass | ||
| with requests.get(url, stream=True) as r: |
There was a problem hiding this comment.
How about:
with requests.get(url,
auth=requests.auth.HTTPBasicAuth(client.email,
client.api_key),
stream=True) as r:where client is controller.client.
There was a problem hiding this comment.
That works. Thanks a lot, @amanagr!
shreyamalviya
force-pushed
the
links-popup
branch
from
3fc02b1 to
51515e1
Compare
Pressing enter on one of the buttons in links popup menu does one of the following, depending on the link: - narrow to stream - narrow to user - open image in system's default viewer - open link in system's default browser Narrows to stream/user and opens images Narrows to stream/user successfuly. Opens selected image in default viewer. Gives 401 error while trying to open gifs or videos. Opens links in default browser Opens links in default browser (code from zulip#397). Tries to download and open user uploaded media in default system viewer (code from zulip#359), otherwise opens link in default browser. Opens images/gifs/links in default system viewer Opens videos in default viewer
shreyamalviya
force-pushed
the
links-popup
branch
from
51515e1 to
3996337
Compare
shreyamalviya
changed the title
|
Heads up @shreyamalviya, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
@shreyamalviya Thanks for your initial work on this 👍 I'm going to close this now since we have a menu structure in place and PRs open for the remaining features (open in web-browser #698, open downloadable media #740). If there were other features which you believe were in this PR and are not integrated, in those PRs, we'd appreciate if you were able to file an issue or mention it briefly on #zulip-terminal - thanks! |
As of now, this does the following:
vFinal functionality includes:
Pressing enter on one of the buttons in the links popup menu does one of the following, depending on the link:
* narrow to stream
* narrow to user
* open image in system's default viewer
* open link in system's default browser