Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics - Track api errors #1936

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Analytics - Track api errors #1936

merged 6 commits into from
Jan 3, 2025

Conversation

araratthehero
Copy link
Contributor

Description

  • Track possible API errors

Checklist

  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-1007

@araratthehero araratthehero added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Dec 23, 2024
@araratthehero araratthehero force-pushed the feature/analytics_track_api_errors branch 2 times, most recently from 6de37aa to 355242e Compare December 24, 2024 11:58
@araratthehero araratthehero marked this pull request as ready for review December 24, 2024 12:22
@araratthehero araratthehero requested a review from a team as a code owner December 24, 2024 12:22
@araratthehero araratthehero changed the title Feature/analytics track api errors Analytics - Track api errors Dec 24, 2024
jreij
jreij approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@jreij jreij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only left one comment but it doesn't have to be addressed in this PR

@araratthehero araratthehero force-pushed the feature/analytics_track_api_errors branch from 355242e to e91f5fe Compare January 3, 2025 12:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

✅ No public API changes

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
78.3% Coverage on New Code (required ≥ 80%)
17.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@araratthehero araratthehero merged commit e377d9a into develop Jan 3, 2025
11 of 12 checks passed
@araratthehero araratthehero deleted the feature/analytics_track_api_errors branch January 3, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreij jreij jreij approved these changes

Assignees
No one assigned
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@araratthehero @jreij