added support for markdown.nvim | changed some native markup/down highlights TBD if final #154
Conversation
…hlights TBD if final
|
|
| @@ -348,17 +349,17 @@ function M.get_groups() | |||
| G['@text.note'] = { link = 'Note' } | |||
| --- Markup | |||
| G['@markup'] = { link = '@none' } | |||
| G['@markup.emphasis'] = { italic = true } | |||
| G['@markup.emphasis'] = { fg = C.orange.base, italic = true } | |||
There was a problem hiding this comment.
I see why you did this, and I think it makes it easier to edit the rendering (by making those things noticeable). However, I think it should just occur on rendered text because it is distracting otherwise.
There was a problem hiding this comment.
Fair enough. That might just be a personal preference, but I noticed it adds so much to a markdown if emphasis, bold, and italic are different colors. Will see if I can make it only apply to rendered text
| G['@markup.italic'] = { italic = true } | ||
| G['@markup.heading.5'] = { fg = C.blue2 } | ||
| G['@markup.heading.6'] = { fg = C.cyan.base } | ||
| G['@markup.italic'] = { fg = C.orange.base, italic = true } |
There was a problem hiding this comment.
same as @markup.emphasis
| G['@markup.strong'] = { bold = true } | ||
| G['@markup.strong'] = { fg = C.orange.base, bold = true } |
There was a problem hiding this comment.
same as @markup.emphasis
|
Appreciate the code review, by the way -- I've never had one. Will get back later today with a revised version |
|
Your welcome; make commits for bold headers (with relinking markdownH1 + markdownH2) and the background blend. I would leave the orange emphasis for Alex to look at, though. |
|
Here are some examples of the orange and not orange markdown section for comparison: Example 1
Example 2
Example 3 (with rendering)
|
|
Just committed changes to 'avih7531:nordic.nvim' hopefully that updated here -- sorry not so good with github!! |
I am assuming you are talking about the one three days ago: 381b17c If not, you still need to push your changes. I had never worked with github before helping with this repo, so don't worry about inexperience. Also, you should be able to see all commits on the |
|
Yes! Commit 381b17c should be what was asked before hand. Changed all headings to bold, re-linked Appreciate your patience and support working with Git! Definitely new to me, but learning. |
|
@5-pebbles Please resolve conversations that you are happy with :) |
|
Alright, @avih7531 I am going to ask that you revert the orange emphasis. I have been using it since this PR was opened, and I still find it a little distracting. It's also fairly easy to add with the new
|
|
Thanks both! Will have that done by tonight -- appreciate giving me some git practice, too |
|
Ping @avih7531 |
|
@avih7531 (•ᴥ• )́ If you would like I could finish this pr... |
|
This will have to get added in a different release. |
Added support for markdown.nvim
Had to change multiple
@markuphighlight groups because of preset bolds and italics, to get a nice lookingRenderMarkdown, but think it came out great.Any thoughts on whether or not to keep the bolds for H1-3 and italics for H5-6 permanently? If so, should they persist in the
RenderMarkdowngroups? My vote would be no as I'm unfamiliar with the convention for highlights like that, but then again, not my repo :)AH