Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S3 String Classes + Add new features to ValidatedStr parent class #24

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

add tests and more backwartd compat w/ full_validate

79fc466
Select commit
Loading
Failed to load commit list.
Open

Update S3 String Classes + Add new features to ValidatedStr parent class #24

add tests and more backwartd compat w/ full_validate
79fc466
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2025 in 0s

96.65% (+0.10%) compared to abc195e

View this Pull Request on Codecov

96.65% (+0.10%) compared to abc195e

Details

Codecov Report

Attention: Patch coverage is 99.18699% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.65%. Comparing base (abc195e) to head (79fc466).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aibs_informatics_core/collections.py 98.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   96.55%   96.65%   +0.10%     
==========================================
  Files          54       54              
  Lines        3544     3561      +17     
  Branches      401      403       +2     
==========================================
+ Hits         3422     3442      +20     
+ Misses         69       68       -1     
+ Partials       53       51       -2     
Files with missing lines Coverage Δ
src/aibs_informatics_core/models/aws/s3.py 97.30% <100.00%> (+0.11%) ⬆️
...rmatics_core/models/demand_execution/parameters.py 96.73% <100.00%> (ø)
src/aibs_informatics_core/models/version.py 92.85% <ø> (ø)
src/aibs_informatics_core/utils/multiprocessing.py 100.00% <ø> (ø)
src/aibs_informatics_core/collections.py 98.19% <98.33%> (+0.53%) ⬆️

... and 1 file with indirect coverage changes