-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCI-1818] Add documentation for CCM EBS shared cost allocation #20994
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small edits, though I'd like verification on one edit to make sure I didn't change the intended meaning.
@@ -52,24 +65,33 @@ ECS tasks that run on Fargate are already fully allocated in the CUR. CCM enrich | |||
|
|||
### Everything else | |||
|
|||
Any cost other than EC2, computed for instances hosting Kubernetes pods or ECS tasks, is given the same value and tags as the source metric, `aws.cost.amortized`. | |||
Cost other than EC2/EBS, computed for instances hosting Kubernetes pods or ECS tasks, is given the same value and tags as the source metric, `aws.cost.amortized`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cost other than EC2/EBS, computed for instances hosting Kubernetes pods or ECS tasks, is given the same value and tags as the source metric, `aws.cost.amortized`. | |
All other costs (costs that are not related to EC2 or EBS, and are not computed for instances hosting Kubernetes pods or ECS tasks) are given the same value and tags as the source metric, `aws.cost.amortized`. |
@kaankoseler I'm trying to reword this sentence to make it more clear. Can you please check that my change doesn't change the intended meaning of the sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cswatt thank you for the review.
This is a tough sentence to work with, I think. The revision does seem to lose the meaning somewhat.
The idea that we are trying to convey is that this subset of costs is what's being targeted with the feature:
EC2/EBS costs for EC2 instances hosting Kubernetes pods or ECS tasks
Any cost that does not fall under that umbrella is considered Everything else
and left as is with the source metric.
So we somehow need to keep that sentence about instances above as one coherent whole, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the list of allocated cost types is growing, this sentence might just not be scalable 😆 I wonder if we even need to re-list all the costs above. One option is just drop the explanation:
"All other costs are given the same value and tags as the source metric, aws.cost.amortized
."
Or, if we want an explanation, to split it up into multiple sentences:
"All other costs are given the same value and tags as the source metric, aws.cost.amortized
. This includes costs for all other AWS services, as well as EC2 and EBS costs not associated with container orchestration."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the former, personally. It should be pretty obvious from the sections and the preceding text of the document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cswatt what do you think about just keeping this as:
"All other costs are given the same value and tags as the source metric, aws.cost.amortized."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "The information on this page pertains to EC2/EBS costs for EC2 instances hosting Kubernetes pods or ECS tasks. All other costs are given the same value and tags as the source metric, aws.cost.amortized
." —does that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that works! cc @enemyghost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to @enemyghost offline, can we slightly modify to say ... pertains to EC2 Compute and EBS costs...
?
Co-authored-by: cecilia saixue watt <[email protected]>
Co-authored-by: cecilia saixue watt <[email protected]>
Co-authored-by: cecilia saixue watt <[email protected]>
Co-authored-by: cecilia saixue watt <[email protected]>
Co-authored-by: cecilia saixue watt <[email protected]>
Co-authored-by: cecilia saixue watt <[email protected]>
Co-authored-by: cecilia saixue watt <[email protected]>
What does this PR do? What is the motivation?
We are releasing a new feature in Cloud Cost Management: shared cost allocation for non-local EBS volumes used as Persistent Volumes in Kubernetes clusters.
Merge instructions
Ideally we will release these in quick succession, with the product feature releasing to all customers first. It's currently org 2 only. We would like to have control of the merge.
Additional notes