Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCI-1818] Add documentation for CCM EBS shared cost allocation #20994
[CCI-1818] Add documentation for CCM EBS shared cost allocation #20994
Changes from 5 commits
afe4368
3f34e5d
79f8507
857b575
f8a5092
026cb2b
fb69269
aa51ed5
7b3dbe1
08ce92a
5825e25
f4bef50
c61f967
c4a0bff
721ad49
41634ce
590a4af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaankoseler I'm trying to reword this sentence to make it more clear. Can you please check that my change doesn't change the intended meaning of the sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cswatt thank you for the review.
This is a tough sentence to work with, I think. The revision does seem to lose the meaning somewhat.
The idea that we are trying to convey is that this subset of costs is what's being targeted with the feature:
EC2/EBS costs for EC2 instances hosting Kubernetes pods or ECS tasks
Any cost that does not fall under that umbrella is considered
Everything else
and left as is with the source metric.So we somehow need to keep that sentence about instances above as one coherent whole, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the list of allocated cost types is growing, this sentence might just not be scalable 😆 I wonder if we even need to re-list all the costs above. One option is just drop the explanation:
"All other costs are given the same value and tags as the source metric,
aws.cost.amortized
."Or, if we want an explanation, to split it up into multiple sentences:
"All other costs are given the same value and tags as the source metric,
aws.cost.amortized
. This includes costs for all other AWS services, as well as EC2 and EBS costs not associated with container orchestration."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the former, personally. It should be pretty obvious from the sections and the preceding text of the document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cswatt what do you think about just keeping this as:
"All other costs are given the same value and tags as the source metric, aws.cost.amortized."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "The information on this page pertains to EC2/EBS costs for EC2 instances hosting Kubernetes pods or ECS tasks. All other costs are given the same value and tags as the source metric,
aws.cost.amortized
." —does that work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that works! cc @enemyghost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to @enemyghost offline, can we slightly modify to say
... pertains to EC2 Compute and EBS costs...
?