-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(navigation): improve url presentation in redirect warning message #13474
base: main
Are you sure you want to change the base?
Conversation
Maybe need to work this more? The spaces look pretty janky and this warning is quite prominent in the report (and honestly URL detection in someone's terminal setup seems low priority :P) |
Embracing the em-dash? That wouldn't solve the period though. nbsp, but that likely wouldn't survive the translation process (though extra spaces probably won't either) |
Honestly I would prefer a larger overhaul to the warning message. It get's pretty hard to read for long URLs: I think it would be better to turn these into links using the markdown renderer like:
|
we can use |
maybe:
@exterkamp did this in PSI... |
Using
We'd have to support a list |
before
after
Padding the url with spaces on either side improves url detection. for example, see how the url is wrong for the old format here:
Closes #15536