Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(navigation): improve url presentation in redirect warning message #13474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const expectations = {
},
},
runWarnings: [
/The page may not be loading as expected because your test URL \(.*js-redirect.html.*\) was redirected to .*redirects-final.html. Try testing the second URL directly./,
/The page may not be loading as expected because your test URL \(.*js-redirect.html.*\) was redirected to \(.*redirects-final.html \)—try testing the second URL directly./,
],
},
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const expectations = {
audits: {
},
runWarnings: [
/The page may not be loading as expected because your test URL \(.*js-redirect.html.*\) was redirected to .*redirects-final.html\?pushState. Try testing the second URL directly./,
/The page may not be loading as expected because your test URL \(.*js-redirect.html.*\) was redirected to \(.*redirects-final.html\?pushState \)—try testing the second URL directly./,
],
},
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const expectations = {
},
},
runWarnings: [
/The page may not be loading as expected because your test URL \(.*online-only.html.*\) was redirected to .*redirects-final.html. Try testing the second URL directly./,
/The page may not be loading as expected because your test URL \(.*online-only.html.*\) was redirected to \(.*redirects-final.html \)—try testing the second URL directly./,
],
},
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const expectations = {
audits: {
},
runWarnings: [
/The page may not be loading as expected because your test URL \(.*js-redirect.html.*\) was redirected to .*redirects-final.html. Try testing the second URL directly./,
/The page may not be loading as expected because your test URL \(.*js-redirect.html.*\) was redirected to \(.*redirects-final.html \)—try testing the second URL directly./,
],
},
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const expectations = {
},
},
runWarnings: [
/The page may not be loading as expected because your test URL \(.*online-only.html.*\) was redirected to .*redirects-final.html. Try testing the second URL directly./,
/The page may not be loading as expected because your test URL \(.*online-only.html.*\) was redirected to \(.*redirects-final.html \)—try testing the second URL directly./,
],
},
};
Expand Down
3 changes: 1 addition & 2 deletions lighthouse-core/gather/driver/navigation.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ const UIStrings = {
* @example {https://example.com/final/resolved/page} final
*/
warningRedirected: 'The page may not be loading as expected because your test URL ' +
`({requested}) was redirected to {final}. ` +
'Try testing the second URL directly.',
`( {requested} ) was redirected to ( {final} )—try testing the second URL directly.`,
/**
* @description Warning that Lighthouse timed out while waiting for the page to load.
*/
Expand Down
2 changes: 1 addition & 1 deletion shared/localization/locales/en-US.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/en-XL.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.