-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add a postgres unix example to actually use a unix socket. #443
Conversation
6eb6eb8
to
3fd3a86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the Postgres Unix example? Should there be a MySQL example? Are we going to link to this anywhere?
Shall we file an issue capturing why we're doing this work?
I would like to have an example for how to use unix sockets. I have added a note to #400 to add documentation in the README that will support this example. I made an example for Postgres but not MySql in order to avoid maintaining redundant examples for each type of database, mysql, postgres, and sql server for a variety of configuration scenarios. |
periodSeconds: 30 | ||
failureThreshold: 3 | ||
exec: | ||
command: ["/bin/sh", "-c", "psql --host=$DB_SOCKET_PATH --port=$DB_PORT --username=$DB_USER '--command=select 1' --echo-queries --dbname=$DB_NAME"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we minimize the need for horizontal scroll here? This really hurts readability otherwise.
3fd3a86
to
b728c91
Compare
- "-e" | ||
- "-c" | ||
- |+ | ||
sleep 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a comment explaining what these two sleep values are for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
b728c91
to
9ea052b
Compare
This provides a new example of how to configure your application to use a unix socket.
This provides a new example of how to configure your application to use a unix socket.