Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color format to depth module in the launch file #3284

Conversation

noacoohen
Copy link

As the D405 does not support an actual RGB sensor, the color format is managed through the depth_module.color_format

Tracked-by RSDSO-19946

@@ -49,6 +49,7 @@
{'name': 'depth_module.infra1_format', 'default': 'Y8', 'description': 'infra1 stream format'},
{'name': 'depth_module.infra2_format', 'default': 'Y8', 'description': 'infra2 stream format'},
{'name': 'depth_module.color_profile', 'default': '0,0,0', 'description': 'Depth module color stream profile'},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you mention d405 for the depth_module.color_profile too, please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Copy link
Collaborator

Nir-Az commented Dec 29, 2024

@remibettan / @noacoohen any idea about the LRS_rosci error?

@Nir-Az Nir-Az merged commit 11bea2e into IntelRealSense:ros2-development Dec 29, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants