Adjust HAProxy's existance to log when the proxy protocol is enabled … #1436
Conversation
|
At some point I remember complaining about this on the Discord aswell, but I think it'd be nicer to mimic what BungeeCord does and log it as a warning on startup, letting the user know proxy protocol is enabled and that it can be a security risk, see https://github.com/SpigotMC/BungeeCord/blob/acb85e30faf3aa10d21ab51efa8fe478f13b8361/proxy/src/main/java/net/md_5/bungee/BungeeCord.java#L335 Warning log would also have the advantage that it would be more visible |
|
I didn't want to be to overbearing. This is a minimal change, but I can adjust it to be a WARNING if needs be |
|
Fully approve this honestly, super helpful for me and my team ha. I swear Velocity used to have this but nope, other proxy software integrations do, with the following message for example: 00:04:18 [WARNING] Using PROXY protocol for listener /0.0.0.0:25565, please ensure this listener is adequately firewalled. I would recommend changing it to WARN. |
…e can see what the preference would be.
|
@clrxbl @JasmeowTheCat |
|
Wohoo! (You cannot imagine the pain I went through with this fata morgana of a feature) |
PaperMC#1436) * Adjust HAProxy's existance to log when the proxy protocol is enabled during bind. * Added additional warning message, instead of changing the main one. We can see what the preference would be.
This is a VERY minor change, so minimal but VERY useful for system administrators. (I am one, and this was so confusing).
Other proxy softwares log when they enable proxy protocol, but velocity doesn't. I probably had some mandella effect, but it seemed like Velocity never used to do this.
But as a system administrator, it would be nice to check the console when the server boots to check if HAProxy is enabled. Hence this change.