Update glow crystals to new coloured blocks palette #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BIG FAN OF THESE |
|
I'm not sure if reflectivity is actually a good fit here, it kind of makes things brighter on the sides, and I'm not so happy about this. |
|
Alright I have decided that this should not block this issue should be resolved by changing the responsible logic and I made an issue for it: #895 |
IntegratedQuantum
requested changes
Jan 7, 2025
| @@ -6,7 +6,7 @@ | |||
| }, | |||
| .transparent = true, | |||
| .hasBackFace = true, | |||
| .absorbedLight = 0xd0c16d, | |||
| .absorbedLight = 0x2f3e92, | |||
There was a problem hiding this comment.
I don't think this is correct, this makes it absorb more blue light, turning it yellow.
| @@ -6,7 +6,7 @@ | |||
| }, | |||
| .transparent = true, | |||
| .hasBackFace = true, | |||
| .absorbedLight = 0x0d36f1, | |||
| .absorbedLight = 0xf2c90e, | |||
There was a problem hiding this comment.
I must have accidentally committed these.
There was a problem hiding this comment.
Okay, reverted the glass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"New" as of... (checks calendar) 9 months ago.
They now have reflectivity textures which enhances the crystal look a lot.
Reminder to how the colours have been renamed:
gray -> grey
dark_gray -> grey
light_blue -> aqua
dark_red -> crimson
dark_green -> viridian