Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent incident #142

Closed
wants to merge 15 commits into from
Closed

Silent incident #142

wants to merge 15 commits into from

Conversation

b0n54i
Copy link

@b0n54i b0n54i commented Oct 1, 2020

Description

This PR adds the option to create private incidents at time of opening an incident using the /hellper_incident command.

image

How to test?

  • Create an silent incident
Feature: /hellper_incident
Given I'm creating an incident 
When I select the 'yes' option in the "This is a silent incident?" field
Then the incident must be created without the  HELLPER_PRODUCT_CHANNEL_ID being notified and the incident channel must be private
  • Resolve an silent incident
Feature: /hellper_resolve
Given a silent incident was created
When I resolve this incident
Then the incident must be resolved without the  HELLPER_PRODUCT_CHANNEL_ID being notified
  • Close an silent incident
Feature: /hellper_close
Given a silent incident was created
When I close this incident
Then the incident must be closed without the  HELLPER_PRODUCT_CHANNEL_ID being notified
  • Cancel an silent incident
Feature: /hellper_cancel
Given a silent incident was created
When I cancel this incident
Then the incident must be canceled without the  HELLPER_PRODUCT_CHANNEL_ID being notified
  • List Active Incidents
Feature: cmd/notify
Given a silent incident was created
When the cron job (./notify) lists active incidents
Then the incident should not appear in this list

@b0n54i b0n54i self-assigned this Oct 1, 2020
@b0n54i b0n54i linked an issue Oct 1, 2020 that may be closed by this pull request
@GLOFonseca GLOFonseca self-requested a review October 21, 2020 12:47
Copy link
Contributor

@GLOFonseca GLOFonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

internal/model/sql/postgres/repository.go Outdated Show resolved Hide resolved
internal/model/sql/postgres/repository.go Show resolved Hide resolved
Copy link
Contributor

@GLOFonseca GLOFonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved.

Testing on the staging environment is important!

@tiagotor tiagotor changed the base branch from master to develop-1-0-0 December 7, 2020 11:39
@tiagotor tiagotor closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open a silent incident
4 participants