Silent incident

docs/CONFIGURING-SLACK.md

@@ -31,6 +31,7 @@
  - usergroups:read
  - users:read
  - users:read.email
+ - groups:write
 ```
 
 ## Slash Commands

internal/bot/dialog_submission.go

@@ -49,4 +49,5 @@ type Submission struct {
 	PostMortemMeeting   string `json:"post_mortem_meeting"`
 	PauseNotifyTime     string `json:"pause_notify_time"`
 	PauseNotifyReason   string `json:"pause_notify_reason"`
+	SilentIncident      string `json:"silent_incident"`
 }

internal/commands/cancel.go

@@ -175,7 +175,7 @@ func CancelIncidentByDialog(
 		return err
 	}
 
-	if notifyOnCancel {
+	if notifyOnCancel && inc.ChannelType == model.TypePublic {
 		err := postAndPinMessage(
 			client,
 			productChannelID,

internal/commands/close.go

@@ -233,7 +233,7 @@ func CloseIncidentByDialog(ctx context.Context, client bot.Client, logger log.Lo
 	var waitgroup sync.WaitGroup
 	defer waitgroup.Wait()
 
-	if notifyOnClose {
+	if notifyOnClose && inc.ChannelType == model.TypePublic {
 		concurrence.WithWaitGroup(&waitgroup, func() {
 			postAndPinMessage(
 				client,
@@ -253,6 +253,7 @@ func CloseIncidentByDialog(ctx context.Context, client bot.Client, logger log.Lo
 		message,
 		channelAttachment,
 	)
+
 	err = client.ArchiveConversationContext(ctx, channelID)
 	if err != nil {
 		logger.Error(

internal/commands/open.go

@@ -123,6 +123,29 @@ func OpenStartIncidentDialog(client bot.Client, triggerID string) error {
 		MaxLength: 500,
 	}
 
+	silentIncident := &slack.DialogInputSelect{
+		DialogInput: slack.DialogInput{
+			Label:       "This is a silent incident?",
+			Name:        "silent_incident",
+			Type:        "select",
+			Placeholder: "Silent Incident",
+			Optional:    false,
+		},
+		Value: "false",
+		Options: []slack.DialogSelectOption{
+			{
+				Label: "Yes",
+				Value: "true",
+			},
+			{
+				Label: "No",
+				Value: "false",
+			},
+		},
+		OptionGroups: []slack.DialogOptionGroup{},
+		Hint:         "A silent incident is characterized by having a private channel and not notifying the main channel of incident when it opens.",
+	}
+
 	dialog := slack.Dialog{
 		CallbackID:     "inc-open",
 		Title:          "Start an Incident",
@@ -136,6 +159,7 @@ func OpenStartIncidentDialog(client bot.Client, triggerID string) error {
 			product,
 			commander,
 			description,
+			silentIncident,
 		},
 	}
 
@@ -168,6 +192,7 @@ func StartIncidentByDialog(
 		product          = submission.Product
 		commander        = submission.IncidentCommander
 		description      = submission.IncidentDescription
+		silentIncident   = submission.SilentIncident
 		environment      = config.Env.Environment
 		matrixURL        = config.Env.MatrixHost
 		supportTeam      = config.Env.SupportTeam
@@ -180,7 +205,17 @@ func StartIncidentByDialog(
 		return fmt.Errorf("commands.StartIncidentByDialog.get_slack_user_info: incident=%v commanderId=%v error=%v", channelName, commander, err)
 	}
 
-	channel, err := client.CreateConversationContext(ctx, channelName, false)
+	hasSilentIncident, err := strconv.ParseBool(silentIncident)
+	if err != nil {
+		logger.Error(
+			ctx,
+			log.Trace(),
+			log.Reason("strconv.ParseBool"),
+			log.NewValue("error", err),
+		)
+	}
+
+	channel, err := client.CreateConversationContext(ctx, channelName, hasSilentIncident)
 	if err != nil {
 		return fmt.Errorf("commands.StartIncidentByDialog.create_conversation_context: incident=%v error=%v", channelName, err)
 	}
@@ -202,6 +237,11 @@ func StartIncidentByDialog(
 		IncidentAuthor:          incidentAuthor,
 		CommanderId:             user.SlackID,
 		CommanderEmail:          user.Email,
+		ChannelType:             model.TypePublic,
+	}
+
+	if hasSilentIncident {
+		incident.ChannelType = model.TypePrivate
 	}
 
 	incidentID, err := repository.InsertIncident(ctx, &incident)
@@ -226,9 +266,25 @@ func StartIncidentByDialog(
 	concurrence.WithWaitGroup(&waitgroup, func() {
 		postAndPinMessage(client, channel.ID, message, attachment)
 	})
-	concurrence.WithWaitGroup(&waitgroup, func() {
-		postAndPinMessage(client, productChannelID, message, attachment)
-	})
+
+	if incident.ChannelType == model.TypePublic {
+		concurrence.WithWaitGroup(&waitgroup, func() {
+			postAndPinMessage(client, productChannelID, message, attachment)
+		})
+
+		_, warning, metaWarning, err := client.JoinConversationContext(ctx, channel.ID)
+		if err != nil {
+			logger.Error(
+				ctx,
+				log.Trace(),
+				log.Reason("JoinConversationContext"),
+				log.NewValue("warning", warning),
+				log.NewValue("meta_warning", metaWarning),
+				log.NewValue("error", err),
+			)
+			return err
+		}
+	}
 
 	//We need run that without wait because the modal need close in only 3s
 	go createPostMortemAndUpdateTopic(ctx, logger, client, fileStorage, incident, incidentID, repository, channel, warRoomURL)

internal/commands/open_test.go

@@ -85,6 +85,7 @@ func TestStartIncidentByDialog(t *testing.T) {
 					Product:             "A",
 					IncidentCommander:   "UYGFQB9C0",
 					IncidentDescription: "Incident Resolved!",
+					SilentIncident:      "false",
 				},
 			},
 		},
@@ -101,6 +102,7 @@ func TestStartIncidentByDialog(t *testing.T) {
 					Product:             "",
 					IncidentCommander:   "",
 					IncidentDescription: "",
+					SilentIncident:      "false",
 				},
 			},
 		},
@@ -118,6 +120,7 @@ func TestStartIncidentByDialog(t *testing.T) {
 					Product:             "",
 					IncidentCommander:   "",
 					IncidentDescription: "",
+					SilentIncident:      "false",
 				},
 			},
 		},

internal/commands/resolve.go

@@ -180,7 +180,7 @@ func ResolveIncidentByDialog(
 			channelAttachment,
 		)
 	})
-	if notifyOnResolve {
+	if notifyOnResolve && inc.ChannelType == model.TypePublic {
 		concurrence.WithWaitGroup(&waitgroup, func() {
 			postAndPinMessage(
 				client,
@@ -190,6 +190,7 @@ func ResolveIncidentByDialog(
 			)
 		})
 	}
+
 	postMessage(client, userID, "", privateAttachment)
 
 	return nil

internal/model/incident.go

@@ -10,6 +10,8 @@ const (
 	StatusCancel   = "canceled"
 	StatusResolved = "resolved"
 	StatusClosed   = "closed"
+	TypePrivate    = "private"
+	TypePublic     = "public"
 )
 
 type Incident struct {
@@ -38,4 +40,5 @@ type Incident struct {
 	IncidentAuthor          string        `db:"incident_author_id,omitempty"`
 	CommanderId             string        `db:"commander_id,omitempty"`
 	CommanderEmail          string        `db:"commander_email,omitempty"`
+	ChannelType             string        `db:"channel_type,omitempty"`
 }

internal/model/sql/postgres/repository.go

@@ -48,6 +48,7 @@ func incidentLogValues(inc *model.Incident) []log.Value {
 		log.NewValue("channelID", inc.ChannelId),
 		log.NewValue("commanderID", inc.CommanderId),
 		log.NewValue("commanderEmail", inc.CommanderEmail),
+		log.NewValue("channelType", inc.ChannelType),
 	}
 }
 
@@ -78,8 +79,9 @@ func (r *repository) InsertIncident(ctx context.Context, inc *model.Incident) (i
 		, channel_name
 		, channel_id
 		, commander_id
-		, commander_email)
-	VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19, $20)
+		, commander_email
+		, channel_type )
+	VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19, $20, $21)
 	RETURNING id`
 
 	id := int64(0)
@@ -105,7 +107,8 @@ func (r *repository) InsertIncident(ctx context.Context, inc *model.Incident) (i
 		inc.ChannelName,
 		inc.ChannelId,
 		inc.CommanderId,
-		inc.CommanderEmail)
+		inc.CommanderEmail,
+		inc.ChannelType)
 
 	switch err := idResult.Scan(&id); err {
 	case nil:
@@ -224,6 +227,7 @@ func (r *repository) GetIncident(ctx context.Context, channelID string) (inc mod
 		&inc.ChannelId,
 		&inc.CommanderId,
 		&inc.CommanderEmail,
+		&inc.ChannelType,
 	)
 
 	r.logger.Info(
@@ -244,8 +248,8 @@ func GetIncidentByChannelID() string {
 		, start_ts
 		, end_ts
 		, identification_ts
-    , snoozed_until
-    , responsibility
+		, snoozed_until
+		, responsibility
 		, functionality
 		, root_cause
 		, customer_impact
@@ -258,6 +262,7 @@ func GetIncidentByChannelID() string {
 		, CASE WHEN channel_id IS NULL THEN '' ELSE channel_id END AS channel_id
 		, CASE WHEN commander_id IS NULL THEN '' ELSE commander_id END commander_id
 		, CASE WHEN commander_email IS NULL THEN '' ELSE commander_email END commander_email
+		, channel_type
 	FROM incident
 	WHERE channel_id = $1
 	LIMIT 1`
@@ -553,6 +558,7 @@ func (r *repository) ListActiveIncidents(ctx context.Context) ([]model.Incident,
 		GetIncidentStatusFilterQuery(),
 		model.StatusOpen,
 		model.StatusResolved,
+		model.TypePrivate,
 	)
 	if err != nil {
 		r.logger.Error(
@@ -641,6 +647,7 @@ func GetIncidentStatusFilterQuery() string {
 		, CASE WHEN commander_email IS NULL THEN '' ELSE commander_email END commander_email
 	FROM incident
 	WHERE status IN ($1, $2)
+	AND channel_type <> ($3)
 	LIMIT 100`
 }
 

internal/model/sql/postgres/schema/hellper.sql

@@ -26,6 +26,7 @@ CREATE TABLE public.incident (
 	channel_id varchar(50) NULL,
   commander_id text NULL,
   commander_email text NULL,
+  channel_type varchar(50) NULL,
 	CONSTRAINT firstkey PRIMARY KEY (id)
 );